From: Sebastian Keller <skeller@gnome.org>
Date: Sun, 12 Feb 2023 17:20:15 +0000 (+0100)
Subject: gdmUtil: Fix SignalTracker leak in ShellUserVerifier
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~405^2^2~19
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=1236bf8f095cca5cc15d5ce012ac4dbc8ff5da6f;p=gnome-shell.git

gdmUtil: Fix SignalTracker leak in ShellUserVerifier

ShellUserVerifier was connecting to UserVerifierChoiceList signals using
SignalTracker, but never disconnected those, leading to the
corresponding SignalTracker being leaked.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6395
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2637>
---

diff --git a/js/gdm/util.js b/js/gdm/util.js
index 3d535659c..78c45cbba 100644
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -520,6 +520,7 @@ var ShellUserVerifier = class extends Signals.EventEmitter {
 
     _disconnectSignals() {
         this._userVerifier?.disconnectObject(this);
+        this._userVerifierChoiceList?.disconnectObject(this);
     }
 
     _getForegroundService() {